Skip to content

[WIP] pkg/daemon: add onceFrom unit test#476

Closed
runcom wants to merge 1 commit intoopenshift:masterfrom
runcom:onceFrom-panic-test
Closed

[WIP] pkg/daemon: add onceFrom unit test#476
runcom wants to merge 1 commit intoopenshift:masterfrom
runcom:onceFrom-panic-test

Conversation

@runcom
Copy link
Member

@runcom runcom commented Feb 22, 2019

Signed-off-by: Antonio Murdaca runcom@linux.com

- What I did

Daemon in onceFrom mode can panic if it goes by a dn.kubeClient.Something call, this is an example that the daemon in onceFrom mode assume a kubeClient...

- How to verify it

run units, it shouldn't panic...

- Description for the changelog

@runcom
pkg/daemon: add onceFrom unit test
9672371 
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom
Copy link
Member Author

runcom commented Feb 22, 2019 •
edited
Loading

/hold

holding until we fix all this I guess? This unit is going to panic anyway, just raising the issue

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 22, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 22, 2019 •
edited
Loading

@runcom: The following tests failed for commit 9672371, say /retest to rerun them:

Test name Details Rerun command
ci/prow/unit link /test unit
ci/prow/e2e-aws-op link /test e2e-aws-op

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ashcrow
Copy link
Member

ashcrow commented Feb 22, 2019 

FAIL	github.com/openshift/machine-config-operator/pkg/daemon	0.021s

... as expected until it's fixed 👍

@runcom runcom mentioned this pull request Feb 23, 2019
Merged
2 tasks
@runcom runcom changed the title pkg/daemon: add onceFrom unit test [WIP] pkg/daemon: add onceFrom unit test Feb 23, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2019
@runcom runcom mentioned this pull request Feb 23, 2019
Merged
@runcom
Copy link
Member Author

runcom commented Feb 23, 2019

closing since #483

@runcom runcom closed this Feb 23, 2019
@runcom runcom deleted the onceFrom-panic-test branch February 23, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@runcom @openshift-ci-robot @ashcrow